Conversation
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
=========================================
- Coverage 10.99% 7.40% -3.59%
=========================================
Files 173 265 +92
Lines 8671 13168 +4497
=========================================
+ Hits 953 975 +22
- Misses 7612 12084 +4472
- Partials 106 109 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| fmt.Printf("Total Vulnerabilities: %s%d%s (Fixable: %s%d%s)\n\n", | ||
| views.BoldANSI, summary.TotalVuls, views.ResetANSI, | ||
| views.BoldANSI, summary.FixableCnt, views.ResetANSI, | ||
| ) |
There was a problem hiding this comment.
Do not use ANSI styling like this. Instead rely on lipgloss.
have a look at the slog PR
There was a problem hiding this comment.
its merged - @Sypher845 - please update
Thanks
| flags.BoolVarP(&withDangerousArtifact, "with-dangerous-artifact", "", false, "Include top 5 dangerous artifact details in summary") | ||
| flags.BoolVarP(&withDangerousCVE, "with-dangerous-cve", "", false, "Include top 5 dangerous CVE details in summary") |
There was a problem hiding this comment.
Can we have either aliases or like short-forms of this?
I feel like writing --with-dangerous-cve and/or the artifact is just too big and tedious.
Something like
--cve & --art or something for shortforms?
Or anything you can suggest
There was a problem hiding this comment.
--cve and --artifact, is this good?
There was a problem hiding this comment.
yeah, that would be good
| } | ||
| } | ||
| empty := barWidth - filled | ||
| bar := e.color + strings.Repeat("█", filled) + views.ResetANSI + strings.Repeat("░", empty) |
There was a problem hiding this comment.
I think we should replace the empty character. Although in mine it shows something like this
And in most modern terminal emulator's they do the same. But for VMs or other cases they look how they do in the PR Description
strings.Repeat("█", filled) + strings.Repeat("─", empty)
// ████████████────────I think this is better. Cause the actual block is standard unicode and so is the -
The half-filled block looks crude to me (this may as well be a personal opinion)
@bupd @qcserestipy What do you think?
There was a problem hiding this comment.
i feel the dot one looks good
There was a problem hiding this comment.
I feel the line one lol
But you can keep the dot, it isnt bad
@qcserestipy @bupd what are your thoughs?
There was a problem hiding this comment.
yeah the line looks good - feels more modern - and across the cli we use lines - so should be good to go..
There was a problem hiding this comment.
2 for 1 - I believe line is the way to go.
| } | ||
| empty := barWidth - filled | ||
| bar := e.color + strings.Repeat("█", filled) + views.ResetANSI + strings.Repeat("░", empty) | ||
| fmt.Printf(" %-10s %s %4d\n\n", e.label, bar, e.count) |
There was a problem hiding this comment.
Can we also add a %age?
Like showing
[XXXXX-----] 43% (4444 CVEs)
Do you think this would be better?
There was a problem hiding this comment.
Yeah , adding it would be better as the UI is also having it.
bupd
left a comment
bupd
left a comment
There was a problem hiding this comment.
@Sypher845 please resolve conflicts
3 participants
Description
The PR adds the new harbor
vuln summary command. A new command that displays an overview of vulnerability data from Harbor's Security Hub.--with-dangerous-artifactflag to show top 5 most vulnerable artifacts--with-dangerous-cveflag to show top 5 most dangerous CVEsType of Change
Please select the relevant type.