Skip to content
This repository was archived by the owner on Aug 8, 2025. It is now read-only.

fix: postgresql not deleted with harborcluster (master)#1014

Open
samuelchen wants to merge 2 commits intogoharbor:mainfrom
samuelchen:fix-postgresql-owner-ref
Open

fix: postgresql not deleted with harborcluster (master)#1014
samuelchen wants to merge 2 commits intogoharbor:mainfrom
samuelchen:fix-postgresql-owner-ref

Conversation

@samuelchen
Copy link
Copy Markdown

@samuelchen samuelchen commented Feb 6, 2023

add ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference .

add ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference .

Signed-off-by: 陈伟 <chen_wei@cestc.cn>
@samuelchen samuelchen force-pushed the fix-postgresql-owner-ref branch from 98b811c to 0f10cfa Compare February 6, 2023 09:24
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this pull request Aug 8, 2023
This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: Shou-En Hsiao <shouenhsiao@google.com>
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this pull request Aug 8, 2023
This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: Shou-En Hsiao <shouenhsiao@google.com>
ShouEnHsiao added a commit to ShouEnHsiao/harbor-operator that referenced this pull request Aug 8, 2023
This CL is from goharbor#1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: ShouEnHsiao <shouenhsiao@google.com>
thcdrt pushed a commit that referenced this pull request Aug 21, 2023
This CL is from #1014
which adds ownerReference to expectCR in PostgreSQLController.Update before comparing.
Origin expectCR have no OwnerReference.

Signed-off-by: ShouEnHsiao <shouenhsiao@google.com>
@steven-zou steven-zou requested a review from cndoit18 September 6, 2024 10:01
Copy link
Copy Markdown
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants