Fixes for s3-sync action#25
Conversation
Split s3-sync.yaml out into dev and stable actions. Dev will run on any branch pull that is not stable. Added DEST_DIR so the sync uploads to 'deployment/latest' for stable and 'deployment/dev' for dev. Otherwise it would upload to the root directory of the bucket. Should address #24
bbriggs
left a comment
bbriggs
left a comment
There was a problem hiding this comment.
We should revisit what conditions trigger a push to the dev cfn template
| name: Upload Cloud Formation - Dev | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
this causes the cfn template to update on all pushes to any branch that isn't stable, which I think is probably not what we want, particularly if there are multiple PRs being worked on in parallel.
There was a problem hiding this comment.
This triggers on non-stable branch pushes, but it uses a different path for DEST_DIR ("deployment/dev" instead of "deployment/latest"), which gives us a way to test dev branches in CloudFormation before they are merged into stable. Regarding the parallel dev branches, we could include the branch name in the DEST_DIR path so each branch was uploaded to a unique location.
|
This second commit includes the branch name in the S3 DEST_DIR path. I reran the action and it correctly copied the cfn template to the /deployment/dev/fix-s3-sync/. Should address @bbriggs ' concern about parallel branches. |
2 participants
Split s3-sync.yaml out into dev and stable actions. Dev will run on any branch pull that is not stable.
Added DEST_DIR so the sync uploads to 'deployment/latest' for stable and 'deployment/dev' for dev. Otherwise it would upload to the root directory of the bucket.
Should address #24