Skip to content

Feat/combobox improvements#1004

Closed
switzerb wants to merge 5 commits into
mainfrom
feat/combobox-improvements
Closed

Feat/combobox improvements#1004
switzerb wants to merge 5 commits into
mainfrom
feat/combobox-improvements

Conversation

@switzerb
Copy link
Copy Markdown
Contributor

Closes

✅ Pull Request Checklist

  • Included link to corresponding GitHub Issue.
  • The commit message follows conventional commit extended guidelines.
  • Added/updated unit tests and storybook for this change (for bug fixes / features).
  • Added/updated visual regression tests for this change (for bug fixes / features).
  • Added/updated documentation (for bug fixes / features)
  • Filled out test instructions.
  • Added changeset (for bug fixes / features).

📝 Test Instructions

❓ Does this PR introduce a breaking change?

  • Yes
  • No

🤖 AI Usage

  • Added corresponding label (ai / human) to PR:

If ai was used, select all that apply:

  • Ideation / brainstorming
  • Documentation
  • Testing
  • Implementation

💬 Other information

@vercel
Copy link
Copy Markdown

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-toolkit Ready Ready Preview, Comment May 21, 2026 10:00pm
map-toolkit Ready Ready Preview, Comment May 21, 2026 10:00pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

🧠 Memory Leak Test Results

Status: ✅ All tests passed

Component Leaks Retained Size Status
accordion-group 0 0 B
accordion 0 0 B
actionbar 0 0 B
avatar 5 110.72 KB
badge 0 0 B
button 0 0 B
dialog 0 0 B
drawer 0 0 B
floating-card 0 0 B
floatingcard 0 0 B
intentional-leak 0 0 B
notice 0 0 B
tooltip 2 44.02 KB
📋 Test Details
  • Components tested: 13
  • Total leaks detected: 7
  • Workflow run: View details

🤖 Generated by MemLab + Playwright

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

📊 Coverage Reports

Coverage Changes by Package

Click to expand 29 package details

apps/next (No diff)

packages/bus (No diff)

packages/constants (No diff)

packages/converters (No diff)

packages/core (No diff)

packages/dataset (No diff)

packages/design-foundation (No diff)

packages/design-toolkit (No diff)

packages/formatters (No diff)

packages/geo (No diff)

packages/hotkey-manager (No diff)

packages/icons (No diff)

packages/logger (No diff)

packages/map-toolkit (No diff)

packages/math (No diff)

packages/ntds (No diff)

packages/postcss-tailwind-css-modules (No diff)

packages/predicates (No diff)

packages/temporal (No diff)

packages/web-worker (No diff)

packages/websocket (No diff)

tooling/biome-config (No diff)

tooling/constellation-tracker (No diff)

tooling/eslint-config (No diff)

tooling/prettier-config (No diff)

tooling/smeegl (No diff)

tooling/turbo-filter (No diff)

tooling/typescript-config (No diff)

tooling/vitest-config (No diff)

Coverage data collected from all packages in the monorepo.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

🖼️ Visual Regression Test Results

Status: ❌ Some tests failed

Metric Count
✅ Passed 2705
❌ Failed 21
Total 2726

❌ Failed Tests

View full test output

Download VRT Report — open report.html for interactive comparison

21 failing tests
Component Failures
ComboBoxField Visual Regression 12
ComboBoxField Open States 9

🔄 Update Snapshots

If these visual changes are intentional, update the baselines:

Option 1 — Fast update (skips re-detection):

gh workflow run visual-regression-update.yml --ref feat/combobox-improvements -f failed_files="src/features/combobox-field/combobox-field.visual.tsx"

Option 2Run manually from Actions UI, paste into the failed_files input:

src/features/combobox-field/combobox-field.visual.tsx

Component Coverage

45 / 54 design-toolkit components have VRT tests (83%)

Missing VRT tests (9 components) - audio - carousel - deferred-collection - floating-card - gantt - lines - media-controls - status-indicator - video
> 4 components excluded: hotkey, icon, skeleton, view-stack --- 🤖 Generated by Vitest Browser + Playwright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant