Feat: Add camera mod pitch/rotation#1009
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📊 Coverage ReportsCoverage Changes by PackageClick to expand 29 package details
Coverage data collected from all packages in the monorepo. |
There was a problem hiding this comment.
-
instead of
modprefix, let's follow the mapping/DOM ecosystem conventions for deltas with a suffixByso modPitch >pitchBy, modRotation >rotateBy -
you should add rotation normalization of 0-360 and pitch clamping to MapLibre's range of 0-85 to avoid returning weird numbers
-
Add tests for this new request (clamping / normalization behavior),
-
The MDX file for the camera needs to be updated to reflect these new functions
Closes n/a
✅ Pull Request Checklist
📝 Test Instructions
useMapCamerashould now returnpitchByandrotateByfunctions. Calling these with a delta should tilt & rotate the camera state by the given delta❓ Does this PR introduce a breaking change?
🤖 AI Usage
If ai was used, select all that apply:
💬 Other information