Skip to content

feat: enable react compiler in design-toolkit#690

Draft
orteth01 wants to merge 5 commits into
mainfrom
to/dtk-react-compiler
Draft

feat: enable react compiler in design-toolkit#690
orteth01 wants to merge 5 commits into
mainfrom
to/dtk-react-compiler

Conversation

@orteth01
Copy link
Copy Markdown

@orteth01 orteth01 commented Dec 17, 2025

enabled react compiler according to tsdown docs: https://tsdown.dev/recipes/react-support#enabling-react-compiler
build time for dtk seems to have increased. from my few tests, ~3s -> ~4.5s. other than that, things seem to be working as they were.

no src code was modified as part of this PR, but going forward we can likely remove manual optimizations that we were doing previously

TODO:

  • populate the nextjs app with the rest of the component variations to ensure no accidental breakage

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
design-toolkit Ready Ready Preview, Comment Dec 18, 2025 6:13pm
map-toolkit Ready Ready Preview, Comment Dec 18, 2025 6:13pm

"react-querybuilder": "~8.10.0",
"rollup-plugin-copy": "^3.5.0",
"storybook": "^9.1.16",
"tinyglobby": "^0.2.15",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was used w/ tsup to add 'use client'; back. we no longer need to do that w/ tsdown and no longer need this dep as a result

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2025

🧠 Memory Leak Test Results

Status: ✅ All tests passed

Component Leaks Retained Size Status
accordion-group 0 0 B
accordion 0 0 B
actionbar 0 0 B
avatar 5 112.44 KB
badge 0 0 B
button 0 0 B
dialog 0 0 B
drawer 0 0 B
intentional-leak 0 0 B
notice 0 0 B
tooltip 2 44.81 KB
📋 Test Details
  • Components tested: 11
  • Total leaks detected: 7
  • Workflow run: View details

🤖 Generated by MemLab + Playwright

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2025

📊 Coverage Reports

Coverage Changes by Package

Click to expand 29 package details

apps/next (No diff)

packages/bus (No diff)

packages/constants (No diff)

packages/converters (No diff)

packages/core (No diff)

packages/dataset (No diff)

packages/design-foundation (No diff)

packages/design-toolkit (No diff)

packages/formatters (No diff)

packages/geo (No diff)

packages/hotkey-manager (No diff)

packages/icons (No diff)

packages/logger (No diff)

packages/map-toolkit (No diff)

packages/math (No diff)

packages/ntds (No diff)

packages/postcss-tailwind-css-modules (No diff)

packages/predicates (No diff)

packages/temporal (No diff)

packages/web-worker (No diff)

packages/websocket (No diff)

tooling/biome-config (No diff)

tooling/constellation-tracker (No diff)

tooling/eslint-config (No diff)

tooling/prettier-config (No diff)

tooling/smeegl (No diff)

tooling/turbo-filter (No diff)

tooling/typescript-config (No diff)

tooling/vitest-config (No diff)

Coverage data collected from all packages in the monorepo.

@brandonjpierce
Copy link
Copy Markdown
Contributor

Confirming this is working:

Screenshot 2025-12-17 at 8 47 24 AM Screenshot 2025-12-17 at 8 47 26 AM Screenshot 2025-12-17 at 8 47 30 AM Screenshot 2025-12-17 at 8 47 31 AM Screenshot 2025-12-17 at 8 47 44 AM

@brandonjpierce
Copy link
Copy Markdown
Contributor

@orteth01 orteth01 marked this pull request as draft December 19, 2025 20:21
@colehart
Copy link
Copy Markdown
Contributor

is this MR ongoing? Hasn't been touched in a month.

@orteth01
Copy link
Copy Markdown
Author

is this MR ongoing? Hasn't been touched in a month.

https://gov.teams.microsoft.us/l/message/19:gcch:49ba58dc77944f2ca1f9063c2aa3bb0f@thread.v2/1766094245177?context=%7B%22contextType%22%3A%22chat%22%7D

tl;dr: yes, still something we want to do. this was side quest/experiment. maybe a more formal 'unassigned' ticket that someone could pick up would help w/ progress on this.

@orteth01
Copy link
Copy Markdown
Author

@colehart thank you for the bump on this! i created a ticket in the core backlog: https://gohypergiant.atlassian.net/browse/PATH-1318.

@switzerb
Copy link
Copy Markdown
Contributor

switzerb commented Feb 4, 2026

yeah this is waiting for the VRT tests to be in place. we can potentially close and reopen, but it's still active work one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants