feat: enable react compiler in design-toolkit#690
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| "react-querybuilder": "~8.10.0", | ||
| "rollup-plugin-copy": "^3.5.0", | ||
| "storybook": "^9.1.16", | ||
| "tinyglobby": "^0.2.15", |
There was a problem hiding this comment.
this was used w/ tsup to add 'use client'; back. we no longer need to do that w/ tsdown and no longer need this dep as a result
🧠 Memory Leak Test ResultsStatus: ✅ All tests passed
📋 Test Details
🤖 Generated by MemLab + Playwright |
📊 Coverage ReportsCoverage Changes by PackageClick to expand 29 package details
Coverage data collected from all packages in the monorepo. |
|
is this MR ongoing? Hasn't been touched in a month. |
tl;dr: yes, still something we want to do. this was side quest/experiment. maybe a more formal 'unassigned' ticket that someone could pick up would help w/ progress on this. |
|
@colehart thank you for the bump on this! i created a ticket in the core backlog: https://gohypergiant.atlassian.net/browse/PATH-1318. |
|
yeah this is waiting for the VRT tests to be in place. we can potentially close and reopen, but it's still active work one way or the other. |




enabled react compiler according to tsdown docs: https://tsdown.dev/recipes/react-support#enabling-react-compiler
build time for dtk seems to have increased. from my few tests, ~3s -> ~4.5s. other than that, things seem to be working as they were.
no src code was modified as part of this PR, but going forward we can likely remove manual optimizations that we were doing previously
TODO: