Skip to content

chore: 🤖 add openspec, stub instance package, spec instance#896

Draft
ArrayKnight wants to merge 1 commit into
mainfrom
feat/instance
Draft

chore: 🤖 add openspec, stub instance package, spec instance#896
ArrayKnight wants to merge 1 commit into
mainfrom
feat/instance

Conversation

@ArrayKnight
Copy link
Copy Markdown
Contributor

@ArrayKnight ArrayKnight commented Mar 7, 2026

Closes https://gohypergiant.atlassian.net/browse/PATH-1549

✅ Pull Request Checklist

  • Included link to corresponding GitHub Issue.
  • The commit message follows conventional commit extended guidelines.
  • Added/updated unit tests and storybook for this change (for bug fixes / features).
  • Added/updated visual regression tests for this change (for bug fixes / features).
  • Added/updated documentation (for bug fixes / features)
  • Filled out test instructions.
  • Added changeset (for bug fixes / features).

📝 Test Instructions

❓ Does this PR introduce a breaking change?

  • Yes
  • No

🤖 AI Usage

  • Added corresponding label (ai / human) to PR:

If ai was used, select all that apply:

  • Ideation / brainstorming
  • Documentation
  • Testing
  • Implementation

💬 Other information

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-toolkit Ready Ready Preview, Comment Mar 7, 2026 0:28am
map-toolkit Ready Ready Preview, Comment Mar 7, 2026 0:28am

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 7, 2026

📊 Coverage Reports

Coverage Changes by Package

Click to expand 30 package details

apps/next (No diff)

packages/bus (No diff)

packages/constants (No diff)

packages/converters (No diff)

packages/core (No diff)

packages/dataset (No diff)

packages/design-foundation (No diff)

packages/design-toolkit (No diff)

packages/formatters (No diff)

packages/geo (No diff)

packages/hotkey-manager (No diff)

packages/icons (No diff)

packages/instance (No diff)

packages/logger (No diff)

packages/map-toolkit (No diff)

packages/math (No diff)

packages/ntds (No diff)

packages/postcss-tailwind-css-modules (No diff)

packages/predicates (No diff)

packages/temporal (No diff)

packages/web-worker (No diff)

packages/websocket (No diff)

tooling/biome-config (No diff)

tooling/constellation-tracker (No diff)

tooling/eslint-config (No diff)

tooling/prettier-config (No diff)

tooling/smeegl (No diff)

tooling/turbo-filter (No diff)

tooling/typescript-config (No diff)

tooling/vitest-config (No diff)

Coverage data collected from all packages in the monorepo.

- `module-registration`: Module registration, unregistration, and local storage with type safety
- `cross-tab-query`: Debounced querying system for discovering modules across registries
- `module-migration`: Two-party handshake protocol for transferring module ownership between tabs
- `highlight-coordination`: Request/clear highlight callbacks with auto-timeout for cross-tab UI feedback
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "highlight" mean in the context of this library? I'm having trouble understanding what this allows the consumer to do

Copy link
Copy Markdown
Contributor Author

@ArrayKnight ArrayKnight Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The highlight feature is intended as a helper when you're interacting with UI on one tab and need context of what target an action has or relationship might exist. Examples:

Yeeting:

  • On Tab A, on a module you want to yeet, show a list of available targets (Tab B, Tab C, etc)
  • On hover of target action, highlight tab (specific style implementation TBD)

Relationship:

  • On Tab A, hover entity on map
  • On Tab B, highlight module or table row of associated entity data

@switzerb
Copy link
Copy Markdown
Contributor

The openspec init here is just default for claude and windsurf? No customizations?

Also, in the process of reviewing this, I have discovered how useful the specs actually are going to be for us.

I had zero idea what problem this new package was solving -- skimmed over the specs and design files and just couldn't put the pieces together what the real-world use cases were. The specs are great for specifics but pretty obtuse for actual understanding. BUT using the specs to explore, ask questions, understand the patterns, asking for real-world scenarios, etc, turned out to be pretty damn useful. And then once it made sense, I could go down the rabbit hole of other ideas very quickly -- like SharedWorkers -- which helps to think about why some of the specific decisions were made...all before any implementation gets written. Plus -- better conversations and more context for decision-making, review when we do end up building something.

In short - I like it. I assume since this is in draft there is more conversation to be had around the design? Are you looking for feedback on system itself?

@colehart
Copy link
Copy Markdown
Contributor

Can this MR be closed in favor of the already merge one from brenna? #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants