chore: 🤖 add openspec, stub instance package, spec instance#896
chore: 🤖 add openspec, stub instance package, spec instance#896ArrayKnight wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📊 Coverage ReportsCoverage Changes by PackageClick to expand 30 package details
Coverage data collected from all packages in the monorepo. |
| - `module-registration`: Module registration, unregistration, and local storage with type safety | ||
| - `cross-tab-query`: Debounced querying system for discovering modules across registries | ||
| - `module-migration`: Two-party handshake protocol for transferring module ownership between tabs | ||
| - `highlight-coordination`: Request/clear highlight callbacks with auto-timeout for cross-tab UI feedback |
There was a problem hiding this comment.
What does "highlight" mean in the context of this library? I'm having trouble understanding what this allows the consumer to do
There was a problem hiding this comment.
The highlight feature is intended as a helper when you're interacting with UI on one tab and need context of what target an action has or relationship might exist. Examples:
Yeeting:
- On Tab A, on a module you want to yeet, show a list of available targets (Tab B, Tab C, etc)
- On hover of target action, highlight tab (specific style implementation TBD)
Relationship:
- On Tab A, hover entity on map
- On Tab B, highlight module or table row of associated entity data
|
The openspec init here is just default for claude and windsurf? No customizations? Also, in the process of reviewing this, I have discovered how useful the specs actually are going to be for us. I had zero idea what problem this new package was solving -- skimmed over the specs and design files and just couldn't put the pieces together what the real-world use cases were. The specs are great for specifics but pretty obtuse for actual understanding. BUT using the specs to explore, ask questions, understand the patterns, asking for real-world scenarios, etc, turned out to be pretty damn useful. And then once it made sense, I could go down the rabbit hole of other ideas very quickly -- like SharedWorkers -- which helps to think about why some of the specific decisions were made...all before any implementation gets written. Plus -- better conversations and more context for decision-making, review when we do end up building something. In short - I like it. I assume since this is in draft there is more conversation to be had around the design? Are you looking for feedback on system itself? |
|
Can this MR be closed in favor of the already merge one from brenna? #923 |
Closes https://gohypergiant.atlassian.net/browse/PATH-1549
✅ Pull Request Checklist
📝 Test Instructions
❓ Does this PR introduce a breaking change?
🤖 AI Usage
If ai was used, select all that apply:
💬 Other information