Skip to content

Update golang_build.py - #34

Open
nicolaair wants to merge 1 commit into
golang:masterfrom
nicolaair:master
Open

Update golang_build.py#34
nicolaair wants to merge 1 commit into
golang:masterfrom
nicolaair:master

Conversation

@nicolaair

Copy link
Copy Markdown

Run all project on fly

Run all project
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@nicolaair

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 7, 2018
@gopherbot

Copy link
Copy Markdown

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/153117.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown

Message from Andrew Bonventre:

Patch Set 1:

Could you provide a bit more context as to what this change is doing? I'm not sure what "Run all project on fly" means.


Please don’t reply on this GitHub thread. Visit golang.org/cl/153117.
After addressing review feedback, remember to publish your drafts!

@nicolaair

Copy link
Copy Markdown
Author

The default script runs the current file, I suggest running the entire project. Thus, it will not matter if the code written on the Golang is in one file or divided into several.

@paulwalk

Copy link
Copy Markdown

I have separately described here the desirable functionality which I believe @devable has implemented in this PR

@gopherbot

Copy link
Copy Markdown

Message from Nik R:

Patch Set 1:

I am so sorry that I have not reacted before. The fact is that I do not have much experience in pull-requesting. During this time, supporters of my pull request appeared and they made a good discussion of this issue, if I may just insert a link: #38


Please don’t reply on this GitHub thread. Visit golang.org/cl/153117.
After addressing review feedback, remember to publish your drafts!

@paulwalk

Copy link
Copy Markdown

Thanks @gopherbot !

@gopherbot

Copy link
Copy Markdown

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/153117.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants