Update golang_build.py - #34
Conversation
Run all project
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/153117. |
|
Message from Andrew Bonventre: Patch Set 1: Could you provide a bit more context as to what this change is doing? I'm not sure what "Run all project on fly" means. Please don’t reply on this GitHub thread. Visit golang.org/cl/153117. |
|
The default script runs the current file, I suggest running the entire project. Thus, it will not matter if the code written on the Golang is in one file or divided into several. |
|
I have separately described here the desirable functionality which I believe @devable has implemented in this PR |
|
Message from Nik R: Patch Set 1: I am so sorry that I have not reacted before. The fact is that I do not have much experience in pull-requesting. During this time, supporters of my pull request appeared and they made a good discussion of this issue, if I may just insert a link: #38 Please don’t reply on this GitHub thread. Visit golang.org/cl/153117. |
|
Thanks @gopherbot ! |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/153117. |
Run all project on fly