Skip to content

fix(hwp): pin renderer fix for body-wide Square tables - #103

Open
mytrashcan wants to merge 3 commits into
golbin:mainfrom
mytrashcan:fix/conference-template-layout
Open

mytrashcan wants to merge 3 commits into
golbin:mainfrom
mytrashcan:fix/conference-template-layout

Conversation

@mytrashcan

Copy link
Copy Markdown

Summary

  • Pin the downstream rhwp renderer fix for body-wide, page-relative Square tables.
  • Preserve the official rhwp v0.8.7 source/tag provenance and record the fork base commit and reason.
  • Verify the fork ancestry, binary artifact provenance, submodule source, and CRLF-safe source hashes in CI.
  • Preserve the generated WASM artifact byte-for-byte with a repository .gitattributes rule.

Implementation

This branch updates the studio submodule and vendored rhwp package to:

Validation

  • CI run: https://github.com/mytrashcan/hop/actions/runs/37923447211
  • All CI jobs passed, including upstream-contract verification, typecheck/build, unit tests, and desktop Rust lint.
  • Local verification: 36 repository tests passed (one legacy shell test skipped), 22 Vitest files / 159 tests passed, and pnpm build:studio passed.

Review limitation

The supplied HWP and screenshot were kept local and were not uploaded to this public repository. The upstream renderer PR carries the corresponding Visual Sweep limitation: no independent Hancom Print PDF was available, so the repository's 90% PDF comparison gate remains explicitly unverified.

Pin the rhwp downstream renderer patch and its freshly built WASM together. Record fork provenance, verify the official base release and prevent silent replacement by the release updater.

Preserve document Square wrapping; reserve the top band only for body-wide tables that intersect the body. Keep source baseline checks portable across CRLF checkouts while verifying artifact bytes exactly.

Validated the original three-page document, text preservation, HWP save/reopen and nine unaffected wrap/placement cases. Engine native tests, WASM clippy/build, HOP upstream checks and studio build passed.
Disable newline conversion for the vendored WASM package so provenance hashes also hold in fresh CRLF-configured clones.
…ncestry

Submodule checkout does not populate tag refs. Fetch the immutable official base tag explicitly and document the same preparation for local verification.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant