feat(makernote/canon): implement Canon MakerNote parser#24
Merged
Conversation
MNI-2 implementation: - Canon handler implementing makernote.Handler interface - Detection based on valid IFD entry count (no header) - Parses all TIFF data types (BYTE, ASCII, SHORT, LONG, RATIONAL, etc.) - Handles inline data (<=4 bytes in value field) - 70+ Canon-specific tag name mappings - Comprehensive unit tests Canon format specifics: - No header - IFD starts at offset 0 - Inherits byte order from parent EXIF - Uses absolute offsets (relative to EXIF TIFF header) - HasNextIFD=false (ignore CR2 non-zero values) Issue #11 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
Review: Canon MakerNote Parser (tech-lead-01)Status: APPROVED ✅ SummaryComprehensive Canon MakerNote implementation matching our design spec. Positive Findings
LGTM. Merging now. |
This was referenced Feb 7, 2026
rpuneet
added a commit
that referenced
this pull request
Feb 7, 2026
Fixes #29 The Canon MakerNote parser was merged (PR #24) but not registered in the MakerNote registry, causing Canon metadata to not be extracted. Canon must be registered LAST as it has no header and uses IFD structure validation as fallback detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code