fix(id3): properly parse COMM and TXXX frames#30
Merged
Conversation
Fixes #20 COMM (Comment) frames were displaying as "Binary data" instead of the actual comment text due to improper handling of the frame structure. Changes: - Fix decodeCommentFrame to properly handle description/comment separator - Add decodeUserTextFrame for TXXX frames - Add support for ID3v2.2 COM frames (in addition to COMM) - Handle edge case where description is missing (backward compat) COMM frame structure: encoding + language + description\0 + comment TXXX frame structure: encoding + description\0 + value Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20
Root Cause
COMM frame structure was not being parsed correctly. The frame has:
The previous code was not properly handling the null-terminated description separator.
Changes
decodeCommentFrame: Properly find description/comment boundarydecodeUserTextFrame: New function for TXXX framesCOMframes (was only handling v2.3/2.4COMM)Test plan
🤖 Generated with Claude Code