Clear iOS text selection after resigning focus - #70
Open
arthurgarzajr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On iOS, selected Textual content can remain highlighted after focus moves into another input, such as a text field or composer. Copying selected text should continue to leave the selection intact, but once the interaction view resigns first responder because another control becomes active, the stale selection should be cleared.
Fix
This clears
model.selectedRangefromUITextInteractionView.resignFirstResponder()aftersuper.resignFirstResponder()succeeds. That keeps copy/share behavior unchanged while tying selection cleanup to the UIKit focus lifecycle.The change is scoped to UIKit because this issue is caused by UIKit first-responder focus changes. AppKit uses a separate selection interaction path, so this PR leaves macOS behavior unchanged.
Validation
make test-ios