Add attributed string postprocessor - #78
Open
tseylerd wants to merge 1 commit into
Open
Conversation
The MarkupParser only runs when the input string changes, so there is no way to add attributes whose source is external to the content. This adds a postprocessing stage that runs after parsing and is re-invoked whenever either the content or the postprocessor itself changes, enabling content-independent customization like search highlighting in both InlineText and StructuredText.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MarkupParseronly runs when the input string changes, so there is no way to add attributes whose source is external to the content (for example, highlight search occurences). Highlighting (or any content-independent customization) currently requires re-parsing and re-rendering which is very inefficient.Solution
Introduces an
AttributedStringPostprocessorprotocol and.textual.attributedStringPostprocessor(_:)modifier that lets callers transform the parsedAttributedStringindependently of markup content. Applies to bothInlineTextandStructuredText.The postprocessor runs after parsing and attachment resolution, and is re-invoked whenever either the parsed attributed string or the postprocessor itself changes. Equality (from
Hashable) drivesonChange-based invalidation, so conforming types reflect state affecting output in their==.Alternatives Considered
MarkupParser: inefficient, requires re-parsing every time without string changes.Testing
swift test --filter AttributedStringPostprocessorTests(3 tests).