Skip to content

fix for 302 redirects where there is a uri tail after the host #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zambien wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for 302 redirects where there is a uri tail after the host #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16b6ff
fix for 302 redirects where there is a uri tail after the host
Mar 11, 2016
6c48261
better solution
Mar 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,14 @@ module.exports = function proxyMiddleware(options) {
, headers = myRes.headers
, location = headers.location;
// Fix the location
if (((statusCode > 300 && statusCode < 304) || statusCode === 201) && location && location.indexOf(options.href) > -1) {
// absoulte path
headers.location = location.replace(options.href, slashJoin('/', slashJoin((options.route || ''), '')));
}
if ((statusCode > 300 && statusCode < 304) && location && location.indexOf(options.href) > -1) {
// don't use absoulte path as it often will be a problem
headers.location = preserveUri(location)
} else if ((statusCode === 201) && location && location.indexOf(options.href) > -1) {
//absoulte path
headers.location = location.replace(options.href, slashJoin('/', slashJoin((options.route || ''), '')));
}

applyViaHeader(myRes.headers, opts, myRes.headers);
rewriteCookieHosts(myRes.headers, opts, myRes.headers, req);
resp.writeHead(myRes.statusCode, myRes.headers);
Expand Down Expand Up @@ -139,3 +143,29 @@ function merge(src1, src2) {
extend(merged, src2);
return merged;
}

//keep any uri bits after the host
function replaceHostPreserveUri(uri, newHost) {
var uriStr = uri,
delimiter = '/',
start = 3,
tokens = uriStr.split(delimiter).slice(start),
result = tokens.join(delimiter);

result = '/' + result

return (newHost === undefined ? result : newHost + result)
}

//keep any uri bits after the host
function preserveUri(uri) {
var uriStr = uri,
delimiter = '/',
start = 3,
tokens = uriStr.split(delimiter).slice(start),
result = tokens.join(delimiter);

result = '/' + result

return result
}