Skip to content

[bot] Merge master/a1e1d82f into rel/dev - #1907

Merged
yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-a1e1d82f-to-rel/dev
Oct 27, 2026
Merged

yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-a1e1d82f-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to a1e1d82 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/40471118321).

chrisbonilla95 and others added 2 commits October 27, 2026 07:51
gen-ai picks the document content format per turn from `options.documentFormat` (`aac-v1` or `aac-v2`) and otherwise from the `enablePublisherV2` flag, which is off for the evaluation org, so the `agent_document_skill` items always ran on the v1 Report names. `ChatClient` now takes `document_format`, validated by `normalize_document_format` when the client is built, and sends it beside `reasoningEffort` in one `options` object that is omitted when both are unset. `run_agentic_document_skill` and `evaluate_agentic_document_skill` take the same argument and validate it before any request. Every turn carries it, since gen-ai keeps a draft in the format of the turn that wrote it. `evaluate_agentic_document_skill` also records it as `document_format` in the dataset-run metadata. It is not part of the run name, so it separates runs in Langfuse only when their names already differ.

jira: LX-3326
risk: low
feat(gooddata-eval): send the document format on agentic document runs
@yenkins-admin
yenkins-admin merged commit adbde3b into rel/dev Oct 27, 2026
1 check passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-a1e1d82f-to-rel/dev branch October 27, 2026 08:05
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7521ebd1-fd2f-4b52-81c9-74d8cc428ec9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.75%. Comparing base (9d8cfcd) to head (a1e1d82).
⚠️ Report is 629 commits behind head on rel/dev.

Additional details and impacted files
@@             Coverage Diff             @@
##           rel/dev    #1907      +/-   ##
===========================================
+ Coverage    85.74%   85.75%   +0.01%     
===========================================
  Files          343      343              
  Lines        25161    25182      +21     
===========================================
+ Hits         21574    21595      +21     
  Misses        3587     3587              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants