Repository navigation
[bot] Merge master/a1e1d82f into rel/dev - #1907
Merged
Merged
Conversation
gen-ai picks the document content format per turn from `options.documentFormat` (`aac-v1` or `aac-v2`) and otherwise from the `enablePublisherV2` flag, which is off for the evaluation org, so the `agent_document_skill` items always ran on the v1 Report names. `ChatClient` now takes `document_format`, validated by `normalize_document_format` when the client is built, and sends it beside `reasoningEffort` in one `options` object that is omitted when both are unset. `run_agentic_document_skill` and `evaluate_agentic_document_skill` take the same argument and validate it before any request. Every turn carries it, since gen-ai keeps a draft in the format of the turn that wrote it. `evaluate_agentic_document_skill` also records it as `document_format` in the dataset-run metadata. It is not part of the run name, so it separates runs in Langfuse only when their names already differ. jira: LX-3326 risk: low
feat(gooddata-eval): send the document format on agentic document runs
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1907 +/- ##
===========================================
+ Coverage 85.74% 85.75% +0.01%
===========================================
Files 343 343
Lines 25161 25182 +21
===========================================
+ Hits 21574 21595 +21
Misses 3587 3587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to a1e1d82 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/40471118321).