Repository navigation
[bot] Merge master/8bca570b into rel/dev - #1914
Merged
Merged
Conversation
PyPI flagged gooddata-sdk 1.79.0 with a "Change of provenance" warning: its attestation came from build-release.yaml, while the previous release (1.78.1.dev4) came from dev-release.yaml. PyPI compares the publishing workflow file with the previous release's, so every stable release that followed a dev release (and vice versa) was flagged. Dev releases now run from build-release.yaml via workflow_dispatch: the branch is bumped to the next N.N.N.devN with tbump (--only-patch, so no commit or tag is created), then built and published. Tag checks, the GitHub release and the Slack notification run only on tag pushes, so stable releases and their release notes are unchanged. dev-release.yaml is removed; its PyPI trusted publisher should be removed too.
scripts/next_dev.sh took gooddata-sdk's latest PyPI version via sort -V, which ranks 1.79.1.dev10 above 1.79.1. After a patch release following 1.79.1.devN builds, the next dev release would have been 1.79.1.devN+1, which pip ranks below the already released 1.79.1. It also ran in each of the 9 build jobs separately, so re-running one failed job after the others had published gave that component a different devN, and it ignored the branch, so a dev release from an old line got master's version. scripts/next_dev_version.py bumps the branch's own version to X.Y.(Z+1) and takes one past the highest X.Y.(Z+1).devN on PyPI across all components. It only compares versions with that exact base, so no general version ordering is involved, and it refuses to run when X.Y.(Z+1) itself is already released (the branch is behind). It also fails on an unexpected PyPI response instead of reading it as "nothing released" and reusing a devN. The prepare job runs the script from the workflow's own revision and reads only pyproject.toml from the requested branch (--pyproject), so dev releases also work from branches that predate the script. It resolves the branch to a commit and computes the version once; every build job uses both, so components always match and re-runs reuse them.
ci: publish dev and stable releases from one workflow
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1914 +/- ##
========================================
Coverage 85.83% 85.83%
========================================
Files 343 343
Lines 25322 25322
========================================
Hits 21735 21735
Misses 3587 3587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 8bca570 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/41446158536).