Skip to content

fix(gooddata-sdk): bump brotli to 1.2.1 for CVE-2026-111497 - #1917

Merged
hkad98 merged 1 commit into
gooddata:masterfrom
hkad98:jkd/bump-brotli
Nov 3, 2026
Merged

hkad98 merged 1 commit into
gooddata:masterfrom
hkad98:jkd/bump-brotli

Conversation

@hkad98

@hkad98 hkad98 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

gooddata-sdk pinned brotli==1.2.0 exactly. CVE-2026-111497 affects brotli >=1.0.3,<1.2.1, so every SDK install pulled in a vulnerable version that users could not override without breaking the pin.

This moves the pin to 1.2.1, the first fixed release, and relocks. In uv.lock, only brotli changes.

Fixes #1900

JIRA: PSDK-234

Summary by CodeRabbit

  • Chores
    • Updated a runtime dependency to a newer patch version.

@hkad98
hkad98 requested review from lupko and pcerny as code owners November 3, 2026 17:45
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The gooddata-sdk runtime dependency declaration updates the pinned Brotli version from 1.2.0 to 1.2.1.

Changes: Brotli dependency update

Layer / File(s) Summary
Update Brotli version pin
packages/gooddata-sdk/pyproject.toml
The SDK dependency declaration changes the pinned Brotli version from 1.2.0 to 1.2.1.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: Low · up to 7df77

The SDK can merge with bounded follow-up, but its shipped dependency inventory should be corrected for accurate attribution.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: bumping the Brotli pin in gooddata-sdk to 1.2.1 to address CVE-2026-111497. The raw summary confirms the only change is the runtime dependency bump in packages/gooddata-sdk…
Linked Issues check Passed [#1900] Requirement: the gooddata-sdk release must permit installing the fixed Brotli 1.2.1 without conflicting with the SDK Brotli pin. The PR changes the Brotli runtime dependency in packages/goodda…
Out of Scope Changes check Passed The reviewable change set is one line in packages/gooddata-sdk/pyproject.toml that bumps the Brotli dependency from 1.2.0 to 1.2.1. This directly implements #1900. The PR description reports that the …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check

Explanation

The title names the change: bumping the Brotli pin in gooddata-sdk to 1.2.1 to address CVE-2026-111497. The raw summary confirms the only change is the runtime dependency bump in packages/gooddata-sdk/pyproject.toml from 1.2.0 to 1.2.1. The title is specific, concise, and matches the main change.

Full details: Linked Issues check

Explanation

[#1900] Requirement: the gooddata-sdk release must permit installing the fixed Brotli 1.2.1 without conflicting with the SDK Brotli pin. The PR changes the Brotli runtime dependency in packages/gooddata-sdk/pyproject.toml from 1.2.0 to 1.2.1 (+1/-1). The PR description states this is an exact pin move to 1.2.1. With the pin at brotli==1.2.1, the issue reproduction pair (gooddata-sdk depends on brotli==1.2.1; user requests brotli==1.2.1) no longer conflicts. The PR description also states that uv.lock changes only Brotli. uv.lock is excluded from review (ignored_files, rule !**/*.lock), so its content was not inspected. The pass does not depend on it, because the required dependency declaration is in the reviewable pyproject.toml. The issue also asks for a Flight Server and FlexConnect release path. That is release coordination in other packages and is non-coding, so it is not assessed against this PR. No automated test change is part of this PR; the issue does not request one.

Full details: Out of Scope Changes check

Explanation

The reviewable change set is one line in packages/gooddata-sdk/pyproject.toml that bumps the Brotli dependency from 1.2.0 to 1.2.1. This directly implements #1900. The PR description reports that the only uv.lock change is the Brotli bump, which is the matching lock update for the same objective. uv.lock was excluded from review, so its exact contents were not inspected. No unrelated change was identified in the reviewable files.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the version pin,
From one point two to one point two one.
A small change hops into the file,
The SDK records the updated number,
And the rabbit bounds along its way.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

gooddata-sdk pinned brotli==1.2.0 exactly. CVE-2026-111497 affects
brotli >=1.0.3,<1.2.1, so every SDK install pulled in a vulnerable
version that users could not override without breaking the pin. Move
the pin to 1.2.1, the first fixed release, and relock (only brotli
changes in uv.lock).

Fixes gooddata#1900

JIRA: PSDK-234
risk: low

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1
packages/gooddata-sdk/pyproject.toml-34-34: 1

34-34: Minor · Security & Privacy · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Update the Brotli license inventory.

packages/gooddata-sdk/LICENSE.txt still lists Brotli (1.1.0), while this declaration installs brotli==1.2.1. Update or regenerate the inventory so the SDK release contains accurate dependency attribution.

Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: da0079fe-e2f2-4da0-adf7-b18ecd3349ec
Commits

Reviewing files that changed from the base of the PR and between 8bca570 and 7df77bf.

Files ignored due to path filters: 1
  • uv.lock is excluded by !**/*.lock
Files selected for processing: 1
  • packages/gooddata-sdk/pyproject.toml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.83%. Comparing base (8bca570) to head (7df77bf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1917   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         343      343           
  Lines       25322    25322           
=======================================
  Hits        21735    21735           
  Misses       3587     3587           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkad98
hkad98 enabled auto-merge November 3, 2026 18:09
@hkad98
hkad98 merged commit 4f5651c into gooddata:master Nov 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gooddata-sdk pins Brotli 1.2.0 and blocks the CVE-2026-111497 fix

2 participants