You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(gooddata-sdk): bump brotli to 1.2.1 for CVE-2026-111497 - #1917
gooddata-sdk pinned brotli==1.2.0 exactly. CVE-2026-111497 affects brotli >=1.0.3,<1.2.1, so every SDK install pulled in a vulnerable version that users could not override without breaking the pin.
This moves the pin to 1.2.1, the first fixed release, and relocks. In uv.lock, only brotli changes.
The SDK can merge with bounded follow-up, but its shipped dependency inventory should be corrected for accurate attribution.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the change: bumping the Brotli pin in gooddata-sdk to 1.2.1 to address CVE-2026-111497. The raw summary confirms the only change is the runtime dependency bump in packages/gooddata-sdk…
Linked Issues check
[#1900] Requirement: the gooddata-sdk release must permit installing the fixed Brotli 1.2.1 without conflicting with the SDK Brotli pin. The PR changes the Brotli runtime dependency in packages/goodda…
Out of Scope Changes check
The reviewable change set is one line in packages/gooddata-sdk/pyproject.toml that bumps the Brotli dependency from 1.2.0 to 1.2.1. This directly implements #1900. The PR description reports that the …
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check
Explanation
The title names the change: bumping the Brotli pin in gooddata-sdk to 1.2.1 to address CVE-2026-111497. The raw summary confirms the only change is the runtime dependency bump in packages/gooddata-sdk/pyproject.toml from 1.2.0 to 1.2.1. The title is specific, concise, and matches the main change.
Full details: Linked Issues check
Explanation
[#1900] Requirement: the gooddata-sdk release must permit installing the fixed Brotli 1.2.1 without conflicting with the SDK Brotli pin. The PR changes the Brotli runtime dependency in packages/gooddata-sdk/pyproject.toml from 1.2.0 to 1.2.1 (+1/-1). The PR description states this is an exact pin move to 1.2.1. With the pin at brotli==1.2.1, the issue reproduction pair (gooddata-sdk depends on brotli==1.2.1; user requests brotli==1.2.1) no longer conflicts. The PR description also states that uv.lock changes only Brotli. uv.lock is excluded from review (ignored_files, rule !**/*.lock), so its content was not inspected. The pass does not depend on it, because the required dependency declaration is in the reviewable pyproject.toml. The issue also asks for a Flight Server and FlexConnect release path. That is release coordination in other packages and is non-coding, so it is not assessed against this PR. No automated test change is part of this PR; the issue does not request one.
Full details: Out of Scope Changes check
Explanation
The reviewable change set is one line in packages/gooddata-sdk/pyproject.toml that bumps the Brotli dependency from 1.2.0 to 1.2.1. This directly implements #1900. The PR description reports that the only uv.lock change is the Brotli bump, which is the matching lock update for the same objective. uv.lock was excluded from review, so its exact contents were not inspected. No unrelated change was identified in the reviewable files.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the version pin, From one point two to one point two one. A small change hops into the file, The SDK records the updated number, And the rabbit bounds along its way.
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
gooddata-sdk pinned brotli==1.2.0 exactly. CVE-2026-111497 affects
brotli >=1.0.3,<1.2.1, so every SDK install pulled in a vulnerable
version that users could not override without breaking the pin. Move
the pin to 1.2.1, the first fixed release, and relock (only brotli
changes in uv.lock).
Fixesgooddata#1900
JIRA: PSDK-234
risk: low
The reason will be displayed to describe this comment to others. Learn more.
Additional comments: 1
packages/gooddata-sdk/pyproject.toml-34-34: 1
34-34: Minor · Security & Privacy · Quick win
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Update the Brotli license inventory.
packages/gooddata-sdk/LICENSE.txt still lists Brotli (1.1.0), while this declaration installs brotli==1.2.1. Update or regenerate the inventory so the SDK release contains accurate dependency attribution.
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Essentials
Run ID: da0079fe-e2f2-4da0-adf7-b18ecd3349ec
Commits
Reviewing files that changed from the base of the PR and between 8bca570 and 7df77bf.
Files ignored due to path filters: 1
uv.lock is excluded by !**/*.lock
Files selected for processing: 1
packages/gooddata-sdk/pyproject.toml
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gooddata-sdkpinnedbrotli==1.2.0exactly. CVE-2026-111497 affects brotli>=1.0.3,<1.2.1, so every SDK install pulled in a vulnerable version that users could not override without breaking the pin.This moves the pin to
1.2.1, the first fixed release, and relocks. Inuv.lock, only brotli changes.Fixes #1900
JIRA: PSDK-234
Summary by CodeRabbit