Repository navigation
[bot] Merge master/c2491992 into rel/dev - #1956
Merged
Merged
Conversation
Four gaps in the checks of the document skill:
- "Add a page" was not checked. `visualizations` accepts a chart
anywhere and `page_charts` lets a kept page hold more charts, so an
edit that pushed the new chart onto an old page passed.
`rework.new_page_charts` lists the charts that must sit on a visible
page outside `keeps_pages`, scored as
`document_new_page_charts_placed`; `keeps_pages` must then list every
page of the open document, which must have no hidden page, or an old
page would count as new.
- `rework.filters` was compared with `==` on the whole wire form, so a
converter that added or dropped one display key failed every rework
item. The document must still have exactly the stated filter ids, but
each filter is compared on its `type` and the other keys the item
states, an attribute filter's `state` on its selection (no values
means all, values in any order), and a date filter's `granularity`,
`from` and `to` even when the item leaves them out: no `from` and `to`
states all time, and an offset means nothing without its granularity.
An attribute filter entry must state its `using` and `state` (null for
all), and a date filter entry its `date`, since an unstated key is not
compared and the filter could move to another label or date dataset. A
filter type other than those two is rejected, since its required keys
are not decided. The selection and value helpers move from the
dashboard grader to `_filters`; only the document grader ignores the
order of a selection's values.
- `period` could only state absolute dates. It can now state a relative
range as a v2 draft carries it in AaC, `{"granularity": "MONTH",
"from": -6, "to": -1}`, with no `type`: the granularity is what tells
it from an absolute `{from, to}`. A draft passes only with the same
range, and a fixture granularity AaC never writes, or a key outside
the period's form, is rejected. The simulated user's reply names the
range the same way.
- Where each chart of a document built from a dashboard applies the
period was not checked. `chart_periods` maps a chart id to the date
dataset the chart applies the period on, or null for a chart the
dashboard's date filter does not reach, which gen-ai marks
`ignore_document_period`. Every placement on a visible page must
agree; scored as `document_chart_periods_correct`.
jira: QA-30024
risk: low
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011CpUh9hFjL8SbdpFxBGRXp
feat(gooddata-eval): check new pages, filters and periods in documents
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1956 +/- ##
===========================================
+ Coverage 86.60% 86.68% +0.07%
===========================================
Files 349 350 +1
Lines 27115 27283 +168
===========================================
+ Hits 23482 23649 +167
- Misses 3633 3634 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to c249199 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/43791117886).