Skip to content

[bot] Merge master/c2491992 into rel/dev - #1956

Merged
yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-c2491992-to-rel/dev
Nov 16, 2026
Merged

yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-c2491992-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to c249199 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/43791117886).

oanhca1367-lgtm and others added 2 commits November 13, 2026 10:12
Four gaps in the checks of the document skill:

- "Add a page" was not checked. `visualizations` accepts a chart
  anywhere and `page_charts` lets a kept page hold more charts, so an
  edit that pushed the new chart onto an old page passed.
  `rework.new_page_charts` lists the charts that must sit on a visible
  page outside `keeps_pages`, scored as
  `document_new_page_charts_placed`; `keeps_pages` must then list every
  page of the open document, which must have no hidden page, or an old
  page would count as new.
- `rework.filters` was compared with `==` on the whole wire form, so a
  converter that added or dropped one display key failed every rework
  item. The document must still have exactly the stated filter ids, but
  each filter is compared on its `type` and the other keys the item
  states, an attribute filter's `state` on its selection (no values
  means all, values in any order), and a date filter's `granularity`,
  `from` and `to` even when the item leaves them out: no `from` and `to`
  states all time, and an offset means nothing without its granularity.
  An attribute filter entry must state its `using` and `state` (null for
  all), and a date filter entry its `date`, since an unstated key is not
  compared and the filter could move to another label or date dataset. A
  filter type other than those two is rejected, since its required keys
  are not decided. The selection and value helpers move from the
  dashboard grader to `_filters`; only the document grader ignores the
  order of a selection's values.
- `period` could only state absolute dates. It can now state a relative
  range as a v2 draft carries it in AaC, `{"granularity": "MONTH",
  "from": -6, "to": -1}`, with no `type`: the granularity is what tells
  it from an absolute `{from, to}`. A draft passes only with the same
  range, and a fixture granularity AaC never writes, or a key outside
  the period's form, is rejected. The simulated user's reply names the
  range the same way.
- Where each chart of a document built from a dashboard applies the
  period was not checked. `chart_periods` maps a chart id to the date
  dataset the chart applies the period on, or null for a chart the
  dashboard's date filter does not reach, which gen-ai marks
  `ignore_document_period`. Every placement on a visible page must
  agree; scored as `document_chart_periods_correct`.

jira: QA-30024
risk: low
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011CpUh9hFjL8SbdpFxBGRXp
feat(gooddata-eval): check new pages, filters and periods in documents
@yenkins-admin
yenkins-admin merged commit f6f056f into rel/dev Nov 16, 2026
1 check passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-c2491992-to-rel/dev branch November 16, 2026 02:17
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b26a5d31-2848-4412-a173-064be12424bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.50980% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.68%. Comparing base (d4e429d) to head (c249199).
⚠️ Report is 654 commits behind head on rel/dev.

Files with missing lines Patch % Lines
...l/src/gooddata_eval/core/agentic/document_skill.py 99.43% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel/dev    #1956      +/-   ##
===========================================
+ Coverage    86.60%   86.68%   +0.07%     
===========================================
  Files          349      350       +1     
  Lines        27115    27283     +168     
===========================================
+ Hits         23482    23649     +167     
- Misses        3633     3634       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants