Skip to content

[bot] Merge master/a607c7aa into rel/dev - #1964

Merged
yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-a607c7aa-to-rel/dev
Nov 18, 2026
Merged

yenkins-admin merged 2 commits into
rel/devfrom
snapshot-master-a607c7aa-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to a607c7a (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/44249189296).

myhoai and others added 2 commits November 18, 2026 11:47
A user who asks for a new chart from an open dashboard without naming a
period may get the dashboard's date filter on the chart, and the product
accepts that as well as an unfiltered chart. The strict date comparison
failed it, which made up most failures of the _ctx visualization
datasets.

The item now says so with expected_output.date_filter_from_context:
true, or {"dataset": "<date dataset>"}. Each candidate without a date
filter is then also scored once per date filter in
user_context.view.dashboard.filters, with that filter added; the
comparison itself is check_filters, unchanged. The dataset comes from
the key, else the dashboard filter's `using` (a bare id gets the
dataset/ prefix), else, for the common date filter, the chart's only
date filter when it is on a dataset/ URI. The key's dataset must be a
bare id or a dataset/ URI, so a typo is a load error. A candidate stating a date filter is not
extended.

A per-item key rather than a run-wide flag: the verdict stays a function
of the dataset item, an item that must reject the dashboard's period
leaves the key out, and the Tavern shim gets it through the expectation
it already relays, with no environment to set.

A derived candidate replaces the best stated one only when it ranks
higher, or ties with it and matches the date it misses, so a chart
failing elsewhere is not also blamed for the date. Among stated
candidates that tie, one that matched the date is preferred, so it keeps
winning over a derived one. The candidate reported
is always the stated one; the detail records filter_date_context and
the failure summary marks the date. Items without the key score exactly
as before.

The single-shot runner now calls an optional Evaluator.validate before
asking the agent, and the visualization evaluator checks its expectation
there. A malformed item, or the key on an item whose context has no
dashboard date filter, errors before any request on every path instead
of after a spent chat turn.

jira: QA-30214
risk: low
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feat(gooddata-eval): per-item dashboard date filter in viz scoring (QA-30214)
@yenkins-admin
yenkins-admin merged commit 821dbdb into rel/dev Nov 18, 2026
1 check passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-a607c7aa-to-rel/dev branch November 18, 2026 06:09
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 26824881-50be-475d-9f7a-862ce2f52d48

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.96%. Comparing base (4176545) to head (a607c7a).
⚠️ Report is 656 commits behind head on rel/dev.

Additional details and impacted files
@@             Coverage Diff             @@
##           rel/dev    #1964      +/-   ##
===========================================
+ Coverage    86.91%   86.96%   +0.04%     
===========================================
  Files          352      352              
  Lines        27694    27781      +87     
===========================================
+ Hits         24070    24159      +89     
+ Misses        3624     3622       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants