Skip to content

[bot] Merge master/b6f29599 into rel/dev - #1967

Merged
yenkins-admin merged 1 commit into
rel/devfrom
snapshot-master-b6f29599-to-rel/dev
Nov 18, 2026
Merged

yenkins-admin merged 1 commit into
rel/devfrom
snapshot-master-b6f29599-to-rel/dev

Conversation

@yenkins-admin

Copy link
Copy Markdown
Contributor

🚀 Automated PR to perform merge from master into rel/dev with changes up to b6f2959 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/44323892850).

* chore(gooddata-api-client): regenerate against staging

A declarative put of document templates and page templates makes the
caller their creator, because the client has no author fields on
either template schema and the SDK cannot send them. The backend has
exposed and restored createdBy, createdAt, modifiedBy and modifiedAt
on both since LX-3490. Regenerating from the staging spec gives
DeclarativePublisherDocumentTemplate and
DeclarativePublisherDocumentPageTemplate the four fields, typed as on
DeclarativePublisherDocument, ready for the SDK to model.

The spec is taken whole, so the regeneration also brings in drift
that nothing in the SDK models yet:

- metricExtensions and visualizationObjectExtensions on the analytics
  layer (DeclarativeMetricExtension,
  DeclarativeVisualizationObjectExtension);
- a DATE_RANGE parameter type (DateRangeParameterDefinition,
  DateRangeParameterValue, ParameterizedDateFilter) and a nullable
  bound on RelativeBoundedDateFilter. The generator flattens a oneOf
  into its last member, so the composed ParameterDefinition and
  JsonApiParameterInAttributesDefinition models now default to
  DATE_RANGE with a DateRangeParameterValue default_value instead of
  STRING with a str;
- DeclarativeMetricPermissionAssignment and
  DeclarativeVisualizationObjectPermissionAssignment are no longer
  nullable;
- localization issues, per-workspace coverage statistics
  (includeCoverage, LocalizationMetadataStatistics.workspaces) and
  child-workspace usage, with their new paths;
- a GOODDATA_AI LLM provider config (GoodDataAiProviderConfig);
- embedding-origin validation (validateEmbeddingOrigin and the
  EMBEDDING_ORIGINS setting), plus the ENABLE_AI_TRACE_OBFUSCATION,
  ENABLE_AI_PERSISTENCE_OBFUSCATION and AI_LAKE_CREDENTIAL_VENDING
  settings;
- a computation profile on result cache metadata, an AFM execution
  progress stream, an AI Lake data source refresh operation and a
  workspace document search path.

No path, schema, property or API tag is removed or renamed, and no
field that was a free-form object gained a type. Nothing in the SDK
uses the parameter definition or permission assignment models above.
The SDK passes type-check and its suite unchanged, and so does
gooddata-pipelines.

jira: LX-3539
risk: low
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(gooddata-sdk): keep template authors through put

Document templates and page templates had no author fields in the
SDK model, so a declarative get dropped createdBy, createdAt,
modifiedBy and modifiedAt and a put sent none. The backend then
stamped the caller as creator of every template, which a workspace
backup and restore turned into the restoring admin and the time of the
restore.

Both template classes now share the analytics base documents already
use, so the four optional fields are read, stored to the template's
layout file, loaded and put back. A template without them still loads
with them empty, and a put without them still makes the caller the
creator. The backend has restored template authors from the payload
since LX-3490.

gdc deploy is unchanged: the Analytics-as-Code form carries no author
fields for any object type, so a deploy makes the deployer the creator
by design.

The round-trip seed gives both templates a non-caller author so a reset
to the caller fails the test. Its cassette is re-recorded separately.

jira: LX-3539
risk: low
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* chore(gooddata-sdk): re-record template author cassette

The round-trip test now seeds a document template and a page template
authored by demo rather than the calling admin, and asserts all four
author fields on both after get, store, load and put. The old cassette
was recorded when templates had no author fields, so the backend had
stamped admin as their creator.

Re-recorded on python-sdk-dex, which runs the backend change that
restores template authors from the layout payload. The recorded
responses carry createdBy, createdAt, modifiedBy and modifiedAt on both
templates, with demo as creator. No other cassette changes.

jira: LX-3539
risk: nonprod
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@yenkins-admin
yenkins-admin merged commit 1752f9a into rel/dev Nov 18, 2026
1 check passed
@yenkins-admin
yenkins-admin deleted the snapshot-master-b6f29599-to-rel/dev branch November 18, 2026 14:24
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0afe2719-aaf1-4025-a5c8-b745e6e66e0d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.96%. Comparing base (669c602) to head (b6f2959).
⚠️ Report is 662 commits behind head on rel/dev.

Additional details and impacted files
@@           Coverage Diff            @@
##           rel/dev    #1967   +/-   ##
========================================
  Coverage    86.96%   86.96%           
========================================
  Files          352      352           
  Lines        27781    27781           
========================================
  Hits         24159    24159           
  Misses        3622     3622           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants