Repository navigation
[bot] Merge master/d0c7e6ba into rel/dev - #1968
Merged
Merged
Conversation
Add the single-shot kind catalog_metadata for the Analytics Catalog generateTitle / generateDescription endpoints. - catalog_input on dataset items: object type, object id, output - client asks again once on a 200 answer with no usable text and records unusable_retries - evaluator: format checks (generated, no note, word / sentence limits, no markup, no ids) plus judge criteria graded like dashboard_summary; expect_note items pass on no text + a note - violation judge decides presence only: the item question carries the object's real metadata, which made the judge grade correctness and score a stated wrong fact as absent - evaluate_catalog_metadata: K-run, gate and Langfuse entry point for the Tavern shim - make calibrate-catalog-metadata with a calibration fixture - the takeaway and catalog clients share the retry predicate and is_transient in core/_retry.py jira: QA-30180 risk: low
- blank text and blank note count as no answer, so they are asked again and never pass as a decline - no_markup also catches single emphasis (*x*, _x_) - format overrides must be a positive integer (limits) or true, false or null; checked before any request - calibration counts an ungraded judge run as a mismatch jira: QA-30180 risk: low
- no_markup: a leading "# of" is a metric name, not a heading - word and sentence counts move to _text_utils; each evaluator passes its own abbreviation list, so catalog keeps "Avg.", "Est.", "U.K." in one sentence and takeaway verdicts stay as they are jira: QA-30180 risk: low
feat(gooddata-eval): evaluate Analytics Catalog title/description
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1968 +/- ##
===========================================
+ Coverage 86.96% 87.07% +0.11%
===========================================
Files 352 355 +3
Lines 27781 28052 +271
===========================================
+ Hits 24159 24427 +268
- Misses 3622 3625 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to d0c7e6b (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/44324671205).