Skip to content

fix: flatten -r/--requirement includes when building temp requirement… - #215

Merged
goodroot merged 2 commits into
goodroot:mainfrom
Tejas242:fix/tmp-requirements-nested-include
Jul 19, 2026
Merged

fix: flatten -r/--requirement includes when building temp requirement…#215
goodroot merged 2 commits into
goodroot:mainfrom
Tejas242:fix/tmp-requirements-nested-include

Conversation

@Tejas242

Copy link
Copy Markdown
Contributor

Fixes #214

Fix

  • Flatten includes via the existing _manifest_closure() helper (already used for dependency-fingerprint hashing) before filtering, so the temp file is self-contained.
  • Replace the inline duplicate in the GPU path with a call to the fixed _filter_requirements().
  • Add a regression test.

Testing

  • python3 -m unittest discover -s tests -p "test_dependency_plans.py"- 13/13 (was 12/12, +1 new)

@Tejas242
Tejas242 requested a review from goodroot as a code owner July 19, 2026 14:15
Copilot AI review requested due to automatic review settings July 19, 2026 14:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Tejas242
Tejas242 force-pushed the fix/tmp-requirements-nested-include branch from 18c16e8 to 7afe23e Compare July 19, 2026 14:34
@goodroot
goodroot merged commit 820ba0f into goodroot:main Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pywhispercpp CPU install fails: -r requirements.txt resolves against /tmp

3 participants