Fix bad-state simulator relaunch via task_manager.is_healthy(). - #391
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_951760337
branch
2 times, most recently
from
July 21, 2026 23:47
e5515a5 to
b2b3959
Compare
copybara-service
Bot
changed the title
task_manager.is_healthy().
copybara-service
Bot
force-pushed
the
test_951760337
branch
3 times, most recently
from
July 22, 2026 11:11
50f091d to
72c849d
Compare
Fix GitHub Issue #390 where `TaskManagerConfig.max_bad_states` set a write-only `_should_restart` flag that was never checked by `Coordinator`, resulting in logs claiming the simulator was restarting when no actual relaunch occurred. Add an `is_healthy()` query method to `TaskManager` that returns `False` when `max_bad_states` is exceeded, and reset bad states on `TaskManager.start()`. Update `Coordinator.rl_reset()` to check `not self._task_manager.is_healthy()` alongside simulator health before relaunching. PiperOrigin-RevId: 952027934
copybara-service
Bot
force-pushed
the
test_951760337
branch
from
July 22, 2026 11:18
72c849d to
c2c35a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bad-state simulator relaunch via
task_manager.is_healthy().Fix GitHub Issue #390 where
TaskManagerConfig.max_bad_statesset a write-only_should_restartflag that was never checked byCoordinator, resulting in logsclaiming the simulator was restarting when no actual relaunch occurred.
Add an
is_healthy()query method toTaskManagerthat returnsFalsewhenmax_bad_statesis exceeded, and reset bad states onTaskManager.start(). UpdateCoordinator.rl_reset()to checknot self._task_manager.is_healthy()alongsidesimulator health before relaunching.