Fix MultiVariateNormalDiag and similar distributions leaking tracers.#290
Open
rainx0r wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
Fix MultiVariateNormalDiag and similar distributions leaking tracers.#290rainx0r wants to merge 1 commit intogoogle-deepmind:mainfrom
rainx0r wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
DiagLinear and DiagPlusLowRankLinear bijectors not being jittable
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi, I can confirm the PR solved the issue I was running into (leaked tracers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
MultiVariateNormalDiagand other such distributions that depend on theDiagLinearandDiagPlusLowRankLineardistributions are not jittable (see #230) because they leak tracers.This means that they cannot be returned from jitted functions. This is a bug because these distributions and bijectors all inherit from
Jittableand yet are not able to be used as inputs or outputs of such functions as intended.The issue is that these bijectors attempt to "inherit" from their internal
_bijectorobjects by doing the following in their__init__method:However, I found that this actually creates a closure over
self._bijectorat trace time which in turn leaks the tracer held withinself._bijector. Simply implementing the corresponding functions that at call-time accessself._bijectorfixes the issue.