Blevitan dev - Retry Logic - #126
Open
blevitan516 wants to merge 18 commits into
Open
blevitan516 wants to merge 18 commits into
blevitan516 wants to merge 18 commits into
Conversation
…And confirm it was properly scheduled.
…sses to separate module and file. Got retries.py working to schedule dynamic dags.
…otFound exception on retry delete.
…e connections after a few days.
…ause issues after a few days.
caiotomazelli
left a comment
caiotomazelli
left a comment
Collaborator
There was a problem hiding this comment.
Overall LGTM, but noted some potential problems and nits below.
PTAL and rebase with the latest changes so that I can take a new look please!
| run_result += target_destination.send_data(data, dry_run) | ||
| offset += batch_size | ||
| ## TESTING ONLY ###################################################### | ||
| # TODO(blevitan): REMOVE this line before merging BLEVITAN_DEV branch into MAIN. |
Collaborator
Author
There was a problem hiding this comment.
will remove when done testing on rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a pull request for the retry logic. I haven't done any testing yet and probably won't have a chance to revisit this for a few weeks, but I wanted to get the code in your hands if you have time to review.