Skip to content

APK installation failures will now raise an exception #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

APK installation failures will now raise an exception #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion android_world/env/adb_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,10 +1056,15 @@ def install_apk(

Raises:
ValueError: If apk location does not exist.
RuntimeError: If the installation failed.
"""
if not os.path.exists(apk_location):
raise ValueError('APK does not exist.')
issue_generic_request(['install', apk_location], env, timeout_sec=30.0)
response = issue_generic_request(
['install', apk_location], env, timeout_sec=30.0
)
if response.status != adb_pb2.AdbResponse.Status.OK:
raise RuntimeError(f'Failed to install APK {apk_location}: {response}')


def check_airplane_mode(env: env_interface.AndroidEnvInterface) -> bool:
Expand Down
Loading