You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
third_party/README.md says the tree ships in wheels, and docs/SETUP.md omits third_party from what a wheel install resolves #146
Both statements about where an installed copy finds third_party/ are wrong, measured on
the wheel built from 1cfe254 and installed into a throwaway venv.
third_party/README.md:4 says the tree "is included in wheels so setup works outside
a source checkout". The wheel contains no third_party entry at all.
docs/SETUP.md:160-165 lists the directories a wheel installation resolves from its
working directory — .env, dependencies/, runs/ — but not third_party/, which harness2/config.py:25 resolves from there too. A user following SETUP exactly still
hits "7 of 7 missing under third_party/".
install.missing_runners() (harness2/install.py:45-62) then returns "benchmark runners and
patches are not included in this copy (7 of 7 missing under third_party/); see
third_party/README.md" — and that README is not in the wheel either, so an installed user
cannot read the file the error message names.
Shipping the tree inside the wheel would not fix this on its own
For a wheel installation PKG.parent is site-packages, which has no pyproject.toml, so ROOT is the working directory — never site-packages. A copy bundled as package data
would therefore stay invisible to THIRD_PARTY, and missing_runners() would keep
reporting 7 of 7 missing. The false claim cannot be made true by packaging alone.
docs/SETUP.md: add third_party/ to that directory list, since config.py:25 resolves
it there and the benchmark error messages depend on it.
If you would rather the wheel carried the tree (package data plus a resolution fallback in config.py), that is a different and larger change and I would send that instead — a word on
which direction you want is enough.
I'd like to work on this: the two-file documentation fix unless you prefer the
wheel-carries-the-tree direction. This is adjacent to #144 / #145, which made the sdist carry
the tree and its provenance manifest; the wheel side is what is left.
Activity