feat: implement schema packaging and runtime loading#555
Open
nan-yu wants to merge 1 commit intogoogle:mainfrom
Open
feat: implement schema packaging and runtime loading#555nan-yu wants to merge 1 commit intogoogle:mainfrom
nan-yu wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces schema packaging and runtime loading capabilities, along with a base InferenceStrategy class and an A2uiSchemaManager. The changes include adding a build hook to copy JSON schemas into the package, updating pyproject.toml to include these assets, and implementing robust schema loading and prompt generation logic. New test files have also been added to cover the new functionality. Dependency updates in uv.lock are also included, which appear to be routine updates.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
fae1210 to
c6f12bb
Compare
- Add a base InferenceStrategy class - Add PackSpecsBuildHook to copy JSON schemas into the package during build time. - Update pyproject.toml to include assets and configure the build hook. - Implement A2uiSchemaManager for robust schema loading, pruning, and prompt generation.
c6f12bb to
c290c91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.