fix(lit): correct HTML attribute binding and state reflection in MultipleChoice [Issue #574]#575
Open
shantoislamdev wants to merge 3 commits intogoogle:mainfrom
Open
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
a756049 to
bfda784
Compare
f243ba1 to
01e95e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two critical bugs in the Lit MultipleChoice component that prevented proper HTML rendering and state reflection.
Issues Fixed:
<option valueContent>instead of<option value="valueContent">.Changes:
value="${option.value}"..valueproperty binding to the<select>element to reflect the current selection fromthis.selections.This brings the Lit implementation into alignment with the Angular renderer, which correctly handles these cases.
Fixes #574
Testing
valueattributesChecklist