feat: add support for custom help triggers#106
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
sadmac7000
left a comment
There was a problem hiding this comment.
I don't think we can change something this fundamental without having at least the option for the old behavior. My preference would be that it default to off.
|
@sadmac7000 I submitted this pull request in 2021. After these years, is it worth making this simple change configurable? If I was the maintainer, I would have merged it and bumped up the major version. |
|
argh exists specifically to implement the Fuchsia command line argument guidelines. Breaking behaviors outside of those guidelines need more than just a major revision bump. They need an update to the guidelines or to be disabled by default. |
|
@sadmac7000 Where is the Fuschia documentation so that I can make the same pull request for that? |
|
The guidelines are documented in Google's git hosting here: https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/docs/development/api/cli.md |
|
@sadmac7000 Reimplemented the help trigger logic to make it configurable through attributes. |
d60c36c to
b8087a0
Compare
|
Looks good. Looks like there's a merge conflict. Mind rebasing? |
|
@sadmac7000 You're welcome. The branch is already rebased. I noticed the GitHub UI can be outdated, so maybe refresh your page. |
|
It's still claiming the branch cannot be rebased due to conflicts and won't let me merge. I refreshed a few times. I'll look again later in case it's a transient error. |
|
@sadmac7000 I gave it a shock. Check if it resolved the issue. Haha |
b8087a0 to
df2bb12
Compare
|
I had to pull it down and manually rearrange it. In the future, please rebase your changes when you need to update rather than merging in upstream. It confuses github. |
Fixes #30
Related to #53
Related to #119
This adds support for custom help triggers using
#[argh(help_triggers("-h", "--help", "help"))].For example,
Allows triggering help with
-h,--helporhelp