argh_shared: change serde features to allow no_std use#183
Open
wgwoods wants to merge 1 commit intogoogle:masterfrom
Open
argh_shared: change serde features to allow no_std use#183wgwoods wants to merge 1 commit intogoogle:masterfrom
argh_shared: change serde features to allow no_std use#183wgwoods wants to merge 1 commit intogoogle:masterfrom
Conversation
The `argh_shared` crate depends on `serde`, which uses `std` in its default configuration. This makes it incompatible with `no_std` crates. As per the [`serde` docs](https://serde.rs/no-std.html), adding `default-features = false` makes it support `no_std`, and adding the `alloc` feature lets it opt back into memory allocation so it can still handle `String`s and such.
sadmac7000
approved these changes
Jan 17, 2024
Collaborator
|
Fancy running in to you XD Looks like the CLA checker might be bugged out but I'll submit this when it gets sorted. |
Collaborator
|
Looks like you'll need to sign the Google CLA for us to land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
argh_sharedcrate depends onserde, which usesstdin its default configuration. This makes it incompatible withno_stdcrates.As per the
serdedocs, addingdefault-features = falsemakes it supportno_std, and adding theallocfeature lets it opt back into memory allocation so it can still handleStrings and such, which is (probably) important here.This could probably also be accomplished by adding a default-on
stdfeature that could be turned off byno_stdusers, but sinceargh's stated goal is small code size it seemed like defaulting tono_std-compatibility was the sanest & simplest change.