Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/typeinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ std::enable_if_t<
std::conjunction_v<common_internal::HasNativeTypeTraitsId<T>,
std::negation<common_internal::HasCelTypeId<T>>>,
TypeInfo>
TypeId(const T& t) {
TypeId(const T& t [[maybe_unused]]) {
return NativeTypeTraits<absl::remove_cvref_t<T>>::Id(t);
}

Expand All @@ -91,7 +91,7 @@ std::enable_if_t<
std::negation<common_internal::HasCelTypeId<T>>,
std::is_final<T>>,
TypeInfo>
TypeId(const T& t) {
TypeId(const T& t [[maybe_unused]]) {
return cel::TypeId<absl::remove_cvref_t<T>>();
}

Expand All @@ -100,7 +100,7 @@ std::enable_if_t<
std::conjunction_v<std::negation<common_internal::HasNativeTypeTraitsId<T>>,
common_internal::HasCelTypeId<T>>,
TypeInfo>
TypeId(const T& t) {
TypeId(const T& t [[maybe_unused]]) {
return CelTypeId(t);
}

Expand Down
2 changes: 1 addition & 1 deletion common/values/list_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ class ListValueBuilder {

virtual size_t Size() const = 0;

virtual void Reserve(size_t capacity) {}
virtual void Reserve(size_t capacity [[maybe_unused]]) {}

virtual ListValue Build() && = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion common/values/map_value.h
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ class MapValueBuilder {

virtual size_t Size() const = 0;

virtual void Reserve(size_t capacity) {}
virtual void Reserve(size_t capacity [[maybe_unused]]) {}

virtual MapValue Build() && = 0;
};
Expand Down
10 changes: 5 additions & 5 deletions eval/public/structs/legacy_type_adapter.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ class LegacyTypeMutationApis {
CelValue::MessageWrapper::Builder& instance) const = 0;

virtual absl::Status SetFieldByNumber(
int64_t field_number, const CelValue& value,
cel::MemoryManagerRef memory_manager,
CelValue::MessageWrapper::Builder& instance) const {
int64_t field_number [[maybe_unused]], const CelValue& value [[maybe_unused]],
cel::MemoryManagerRef memory_manager [[maybe_unused]],
CelValue::MessageWrapper::Builder& instance [[maybe_unused]]) const {
return absl::UnimplementedError("SetFieldByNumber is not yet implemented");
}
};
Expand Down Expand Up @@ -116,8 +116,8 @@ class LegacyTypeAccessApis {
// whether the leaf field is set to a non-default value.
virtual absl::StatusOr<LegacyQualifyResult> Qualify(
absl::Span<const cel::SelectQualifier>,
const CelValue::MessageWrapper& instance, bool presence_test,
cel::MemoryManagerRef memory_manager) const {
const CelValue::MessageWrapper& instance [[maybe_unused]], bool presence_test [[maybe_unused]],
cel::MemoryManagerRef memory_manager [[maybe_unused]]) const {
return absl::UnimplementedError("Qualify unsupported.");
}

Expand Down
6 changes: 3 additions & 3 deletions eval/public/structs/legacy_type_info_apis.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class LegacyTypeInfoApis {
const MessageWrapper& wrapped_message) const = 0;

virtual const google::protobuf::Descriptor* absl_nullable GetDescriptor(
const MessageWrapper& wrapped_message) const {
const MessageWrapper& wrapped_message [[maybe_unused]]) const {
return nullptr;
}

Expand All @@ -84,7 +84,7 @@ class LegacyTypeInfoApis {
//
// Nullptr signals that the value does not provide mutation apis.
virtual const LegacyTypeMutationApis* GetMutationApis(
const MessageWrapper& wrapped_message) const {
const MessageWrapper& wrapped_message [[maybe_unused]]) const {
return nullptr;
}

Expand All @@ -93,7 +93,7 @@ class LegacyTypeInfoApis {
// The underlying string is expected to remain valid as long as the
// LegacyTypeInfoApis instance.
virtual absl::optional<FieldDescription> FindFieldByName(
absl::string_view name) const {
absl::string_view name [[maybe_unused]]) const {
return absl::nullopt;
}
};
Expand Down
2 changes: 1 addition & 1 deletion eval/public/structs/proto_message_type_adapter.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class ProtoMessageTypeAdapter : public LegacyTypeInfoApis,
const MessageWrapper& wrapped_message) const override;

const google::protobuf::Descriptor* absl_nullable GetDescriptor(
const MessageWrapper& wrapped_message) const override {
const MessageWrapper& wrapped_message [[maybe_unused]]) const override {
return descriptor_;
}

Expand Down
4 changes: 2 additions & 2 deletions runtime/internal/attribute_matcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ class AttributeMatcher {

// Checks whether the attribute trail matches any unknown patterns.
// Used to identify and collect referenced unknowns in an UnknownValue.
virtual MatchResult CheckForUnknown(const Attribute& attr) const {
virtual MatchResult CheckForUnknown(const Attribute& attr [[maybe_unused]]) const {
return MatchResult::NONE;
};

// Checks whether the attribute trail matches any missing patterns.
// Used to identify missing attributes, and report an error if referenced
// directly.
virtual MatchResult CheckForMissing(const Attribute& attr) const {
virtual MatchResult CheckForMissing(const Attribute& attr [[maybe_unused]]) const {
return MatchResult::NONE;
};
};
Expand Down