chore: formalize book.js patching #3000
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formalize
book.jsPatchingDescription
This PR formalizes the process of patching
book.js.Previously,
theme/book.jscontained custom modifications (Google Analytics) but there was no clear separation from the upstreammdBookcode, andthird_party/mdbook/book.jswas a symlink to this modified file.This change:
third_party/mdbook/book.jsto its pristine upstream state (matchingmdBookversion used).patches/book.js.patchfile containing the custom Google Analytics integration.xtask patch-assetscommand to automatically apply this patch.xtask install-toolsto runpatch-assets, ensuring the environment is always correctly set up.Verification
cargo xtask patch-assetsto verify the patch applies cleanly.theme/book.jsto confirmgtagcalls are present.cargo xtask serveto verify the book builds and serves correctly.Fixes #2924