[TS] Fix relative import paths of generated TypeScript code#8880
[TS] Fix relative import paths of generated TypeScript code#8880auschi-shieldai wants to merge 16 commits intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bjornharrtell
left a comment
There was a problem hiding this comment.
Looks good to me!
|
@auschi-shieldai sorry this has been taking so long but I'd like to help get this moving now... however, it now needs resolve conflicts with main. Is that something you can do? |
@bjornharrtell no worries at all! I'll get the merge conflicts resolved here in the next couple of hours and re-request your review once changes are pushed up. Thank you! |
|
@auschi-shieldai sorry but seems something isn't right (see test failures) |
|
@bjornharrtell I'm a little swamped today, so I plan on taking a look and getting it fixed later tonight. I imagine something got a little funky after resolving those merge conflicts |
Head branch was pushed to by a user without write access
This reverts commit 0f0b24a.
This PR fixes two issues:
A new test suite has been added to validate relative import paths, as well as the fix itself.
This PR also sneaks a couple linting/formatting fixes in for unrelated parts of the
idl_gen_ts.cpfile.