Skip to content

Add GitHub Actions Mode Validation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mitchspano merged 7 commits into from
Apr 27, 2025
Merged

Add GitHub Actions Mode Validation #49

mitchspano merged 7 commits into from
Apr 27, 2025

Conversation

@mitchspano
Copy link
Collaborator

@mitchspano mitchspano commented Apr 27, 2025

  1. GitHub Actions Validation

    • Added strict validation for GitHub Actions mode
    • Enforces Mermaid diagrams and specific git hashes (HEAD^1 → HEAD)
    • Improves error reporting with clear, actionable messages

  2. Dependency Updates

    • Updated @std packages to latest versions
    • Removed unused dependencies
    • Migrated to Deno's native file operations in a few places.
    • NOTE: some Node file module calls remain throughout the project. These will need to be cleaned up in the future.

  3. Test Improvements

    • Added comprehensive GitHub Actions mode tests
    • Reorganized tests using Deno's t.step pattern

Fixes #35

mitchspano and others added 7 commits April 26, 2025 19:59
@mitchspano
Update Deno dependencies and enhance argument processing
6396d05 
- Bump versions of several Deno standard libraries in deno.json and deno.lock for improved functionality and security.
- Refactor argument processing in ArgumentProcessor to validate GitHub Action configurations, ensuring required parameters are set correctly.
- Replace Node.js file system operations with Deno's native file system methods for better compatibility.
- Add comprehensive tests for GitHub Action mode validation in argument_processor_test.ts to ensure correct error handling.
- Update UML writing logic in uml_writer.ts to utilize Deno's file system methods, enhancing performance and reliability.
- Refactor XML reading logic in xml_reader.ts to use Deno's file system methods, improving error handling and compatibility.
@mitchspano
Refactor Deno configuration and enhance argument processing tests
1871460 
- Remove unnecessary compiler options from deno.json for cleaner configuration.
- Update test command in deno.json to include additional permissions for improved testing capabilities.
- Refactor argument processing tests in argument_processor_test.ts for better readability and consistency, ensuring proper error handling for various configurations.
@mitchspano
Refactor argument processing tests for GitHub Action mode validation
76b7baf 
- Update test descriptions for clarity and consistency, ensuring they follow a standardized format.
- Enhance tests to validate valid and invalid configurations for GitHub Action mode, including checks for diagram tool and git diff hashes.
- Improve error handling assertions to ensure accurate feedback for multiple invalid configurations.
@mitchspano
Remove unused function in uml_writer_test
c027aeb
@mitchspano
Remove unused dependencies from Deno configuration
b81ea72 
- Eliminate jasmine and yargs from deno.json and deno.lock as they are no longer needed, streamlining the project dependencies.
@mitchspano
Update JSR package version number
e816936
@mitchspano
Format using deno fmt
6fbb3e5
@mitchspano mitchspano merged commit a0f0777 into main Apr 27, 2025
2 checks passed
@mitchspano mitchspano deleted the arg_validation branch April 27, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Validation for GitHub Action Mode

1 participant

@mitchspano