Fix implicit-to-explicit-plus conversion in jsonnetfmt#853
Merged
johnbartholomew merged 4 commits intogoogle:masterfrom Feb 24, 2026
Merged
Fix implicit-to-explicit-plus conversion in jsonnetfmt#853johnbartholomew merged 4 commits intogoogle:masterfrom
johnbartholomew merged 4 commits intogoogle:masterfrom
Conversation
There were various bits of dead code and easily simplified things.
johnbartholomew
force-pushed
the
fmt-bug-809
branch
from
b45a6fc to
5400c70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicit plus and explicit plus have different precedence, so when converting from implicit to explicit plus sometimes it's necessary to introduce parentheses so that the parse tree for the formatted output is correct.
jsonnetfmt previously did not do this. It is only relevant when using the
--no-use-implicit-plusoption to jsonnetfmt.Fixes #809
Also related #496