[JsonConverter]: Support generators with constructor arguments#1375
Open
phuongvt wants to merge 1 commit intogoogle:masterfrom
Open
[JsonConverter]: Support generators with constructor arguments#1375phuongvt wants to merge 1 commit intogoogle:masterfrom
phuongvt wants to merge 1 commit intogoogle:masterfrom
Conversation
Issue: Can't custom JsonConverter with constructor arguments [google#1373]
Collaborator
|
We'll need a changelog update and tests here, please! |
kevmoo
requested changes
Jan 16, 2024
Collaborator
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
changelog entry and tests, please
Author
@kevmoo : I'm not sure I understand what you mean. Please give me a template for me to follow. Thank you! |
Collaborator
We need to have tests for any changes you make, ideally showing the new behavior! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Issue: Can't custom JsonConverter with constructor arguments [#1373]