Improve error message when generating code for Record types with unsupported fields#1561
Improve error message when generating code for Record types with unsupported fields#1561
Conversation
…pported fields Fixes #1559 json_serializable/lib/src/utils.dart: Updated typeToCode to properly handle RecordType. Now correctly formats record types (including nullable and nested records) and falls back to getDisplayString() for unsupported types like FunctionType instead of throwing UnimplementedError. json_serializable/test/src/_json_serializable_test_input.dart: Added regression tests for records with unsupported types and multiple converters on records. json_serializable/test/json_serializable_test.dart: Added new tests to the expected test list. json_serializable/CHANGELOG.md: Added changelog entry.
Summary of ChangesHello @kevmoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves error handling for Record types with unsupported fields by updating typeToCode to fall back to getDisplayString() instead of throwing an UnimplementedError. This allows for more informative error messages. The change also includes a robust implementation for converting RecordType to its string representation and adds comprehensive regression tests for records with unsupported types and for cases with multiple converters. My feedback focuses on improving the maintainability of the new code.
| } | ||
|
|
||
| @ShouldThrow( | ||
| 'Could not generate `fromJson` code for `record` because of type ' |
There was a problem hiding this comment.
Too many test cases in here!
Really only need one for the bad type and one for the converter bit!
1 participant
Fixes #1559
json_serializable/lib/src/utils.dart: Updated typeToCode to properly handle RecordType. Now correctly formats record types (including nullable and nested records) and falls back to getDisplayString() for unsupported types like FunctionType instead of throwing UnimplementedError.
json_serializable/test/src/_json_serializable_test_input.dart: Added regression tests for records with unsupported types and multiple converters on records.
json_serializable/test/json_serializable_test.dart: Added new tests to the expected test list.
json_serializable/CHANGELOG.md: Added changelog entry.