Skip to content

Comments

chore: avoid recompute length in std.slice#1241

Merged
johnbartholomew merged 1 commit intogoogle:masterfrom
He-Pin:slice_length
Jan 31, 2026
Merged

chore: avoid recompute length in std.slice#1241
johnbartholomew merged 1 commit intogoogle:masterfrom
He-Pin:slice_length

Conversation

@He-Pin
Copy link
Contributor

@He-Pin He-Pin commented May 13, 2025

Motivation:
Avoid some recomutaion.

@johnbartholomew johnbartholomew marked this pull request as draft January 31, 2026 13:22
@johnbartholomew johnbartholomew marked this pull request as ready for review January 31, 2026 13:22
@johnbartholomew
Copy link
Collaborator

Sorry, I messed this one up. It is rebased and on master, I just failed to follow my normal process and github lost the link from this PR to the rebased commit.

@johnbartholomew
Copy link
Collaborator

I had to fully remove this, as I didn't realise you haven't signed the CLA. Unfortunately by policy I'm not allowed to accept changes without the CLA being accepted.

@He-Pin
Copy link
Contributor Author

He-Pin commented Jan 31, 2026

image

@He-Pin
Copy link
Contributor Author

He-Pin commented Jan 31, 2026

@johnbartholomew I have signed the cla

@johnbartholomew johnbartholomew merged commit c707683 into google:master Jan 31, 2026
25 checks passed
@He-Pin He-Pin deleted the slice_length branch January 31, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants