Merged
Conversation
Collaborator
johnbartholomew
commented
Feb 10, 2026
johnbartholomew
commented
- Delete the Golang overrides; they should all be in the go-jsonnet repo (see Chore: import golang golden overrides from cpp-jsonnet go-jsonnet#845)
- Put test output in a temporary directory instead of writing lots of files to the source dir.
johnbartholomew
force-pushed
the
cleanup-tests
branch
from
bdc466f to
3f55e04
Compare
johnbartholomew
force-pushed
the
cleanup-tests
branch
from
5600ef2 to
3560b6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.