Repository navigation
Conversation
Contributor
Author
|
This issue was also fixed in #462, which has now merged. I verified that all five regression cases from this PR pass against current main. Closing this as superseded. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
UHDR_BUILD_DEPS=OFF, the gain-map check can fail even when the installed libheif supports it. If libheif exports multiple compile definitions, only the first gets a-Dprefix. The compiler treats the remaining definitions as input files, so configuration completes with HEIF/AVIF support disabled.This change adds
-Dto each definition and keeps the existing compile-only check. The regression tests cover absent, empty, single and multiple definitions, plus a header without the gain-map API.The regression fails before the fix and passes afterward on macOS and Linux. A Linux build with an installed patched libheif also detects support without overriding the check and passes an AVIF encode/decode smoke test. Fork CI passed on Windows (MSVC), Linux, macOS and Android, including all five new regression cases on Windows.