Repository navigation
Conversation
Clean linked extension packets while preserving user metadata, updating the digest and standard XMP link, and removing empty packets. Validate linked chunk coverage before writing output and cover preservation and malformed input with regression tests.
DichenZhang1
pushed a commit
that referenced
this pull request
Oct 9, 2026
Clean linked extension packets while preserving user metadata, updating the digest and standard XMP link, and removing empty packets. Validate linked chunk coverage before writing output and cover preservation and malformed input with regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uhdr_strip_gain_map()can remove the gain-map image but leave its metadata in Extended XMP. This happens when the linked packet contains gain-map properties alongside ordinary user metadata.This change removes those properties while preserving the user metadata and updating the packet digest and its link in standard XMP. If nothing remains in the packet, its chunks and link are removed. The JPEG image data is unchanged, and unrelated extension segments are preserved.
Incomplete or inconsistent linked chunks are rejected before writing to the output buffer.
Validation: 20 focused tests pass in the dual XMP/ISO build, 15 in the ISO-only build, and five with AddressSanitizer and UndefinedBehaviorSanitizer. An independent JPEG check also confirms valid updated XMP, preserved user metadata, and identical compressed image data and decoded pixels.