Embed Filter Data and Improve Compatability#12
Open
BrandenAvalonCx wants to merge 1 commit intogoogle:masterfrom
Open
Embed Filter Data and Improve Compatability#12BrandenAvalonCx wants to merge 1 commit intogoogle:masterfrom
BrandenAvalonCx wants to merge 1 commit intogoogle:masterfrom
Conversation
…ed on construction.
yeroro
reviewed
Nov 25, 2025
| #include "binaural_filters_1_oa_ambient_l.h" | ||
|
|
||
| #include <vector> | ||
| #include <span> |
Collaborator
There was a problem hiding this comment.
I like the direction of eliminating redundant allocation. I just have one ask: can we use absl::Span instead of std::span? Functionally they are almost identical, it's just a preference for code inside Google. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two suggested changes here:
Roll back to Abseil version 20250512.1 to maintain compatibility with the Protocol Buffer library.
Move filters to std::spans