tp: add Sort and GroupBy operators to the executor - #7690
Draft
LalitMaganti wants to merge 1 commit into
Draft
LalitMaganti wants to merge 1 commit into
LalitMaganti wants to merge 1 commit into
Conversation
Operators which need their input ordered should not order it themselves: the plan should, so it can skip the work when the input is already in order. These are the two operators it uses. Sort sorts rows stably by numeric keys through RowLayout. GroupBy puts rows with equal keys next to each other with a counting sort, keeping their order within each group, and numbers the groups.
LalitMaganti
added this pull request to stack #7680
September 29, 2026 23:53
🎨 Perfetto UI Builds & Tests
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operators which need their input ordered should not order it themselves:
the plan should, so it can skip the work when the input is already in
order. These are the two operators it uses.
Sort sorts rows stably by numeric keys through RowLayout. GroupBy puts
rows with equal keys next to each other with a counting sort, keeping
their order within each group, and numbers the groups.