Repository navigation
tp: speed up critical_blocking_calls - #7774
Merged
Merged
Conversation
🎨 Perfetto UI Builds & Tests
|
Short-circuit the handler pattern globs on '*$*', filter matching names from slice before SELECT DISTINCT so android_standardize_slice_name() runs once per unique matching name, and reuse the materialized thread_slice scan across downstream tables without redundant thread joins. Speeds up android.critical_blocking_calls by ~4.3x across 200k-1M slice traces with zero output diff against main. Change-Id: Idcd067421346d3a743e3d4a4afb8b7226334c9bc
nicomazz
force-pushed
the
dev/nicomazz/optimize-critical-blocking-calls
branch
from
October 9, 2026 16:39
3d9ee54 to
0503949
Compare
nicomazz
changed the title
nicomazz
marked this pull request as ready for review
October 9, 2026 16:46
nicomazz
enabled auto-merge (squash)
October 9, 2026 16:46
LalitMaganti
approved these changes
Oct 9, 2026
lukaville
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-circuit the handler pattern globs on
'*$*', filter matching names fromslicebeforeSELECT DISTINCTsoandroid_standardize_slice_name()runs once per unique matching name instead of once per matchingthread_slicerow, and reuse the materializedthread_slicescan across downstream tables without redundantthreadjoins.Benchmarks (
android.critical_blocking_callsmodule load time)main2026-04-16_14-13-39dc562026-05-11_14-16-4876012026-06-12_18-03-8c2956