Repository navigation
tp: fix manifest offset_ns ignored for snapshot-less proto files - #7876
Merged
Merged
Conversation
A perfetto_manifest clock override adds an edge from the file's source clock (the named `clock`, or the file's private TraceFile clock when pinned) to the reference clock. #6399 dropped setting that clock as the file's default, so proto files without ClockSnapshots or timestamp_clock_id never went through the edge and offset_ns was silently ignored. Restore it, for both the pinned and named-clock forms. Also reject offset_ns placed inside sync_to instead of ignoring it.
🎨 Perfetto UI Builds & Tests
|
Member
Author
safayat-google
approved these changes
Oct 12, 2026
safayat-google
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A perfetto_manifest clock override adds an edge from the file's source
clock (the named
clock, or the file's private TraceFile clock whenpinned) to the reference clock. #6399 dropped setting that clock as the
file's default, so proto files without ClockSnapshots or
timestamp_clock_id never went through the edge and offset_ns was
silently ignored. Restore it, for both the pinned and named-clock forms.
Also reject offset_ns placed inside sync_to instead of ignoring it.