Repository navigation
tp: allow TRACE_FILE as a clock name in manifest clocks blocks - #7877
Open
LalitMaganti wants to merge 1 commit into
Open
LalitMaganti wants to merge 1 commit into
LalitMaganti wants to merge 1 commit into
Conversation
LalitMaganti
added this pull request to stack #7878
October 9, 2026 21:10
🎨 Perfetto UI Builds & Tests
|
LalitMaganti
force-pushed
the
dev/lalitm/manifest-trace-file-clock
branch
2 times, most recently
from
October 9, 2026 21:18
3e3f9df to
162f5eb
Compare
The file's private per-file timeline could only be selected by omitting `clock` / `sync_to.clock`. Accept "TRACE_FILE" as an explicit spelling of the same thing on both sides. Also accept it for trace_time.clock (with a required trace_time.file and no machine) to make that file's private timeline the trace time.
LalitMaganti
force-pushed
the
dev/lalitm/manifest-trace-file-clock
branch
from
October 9, 2026 21:19
162f5eb to
d63733d
Compare
Member
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file's private per-file timeline could only be selected by omitting
clock/sync_to.clock. Accept "TRACE_FILE" as an explicit spelling ofthe same thing on both sides.
Also accept it for trace_time.clock (with a required trace_time.file and
no machine) to make that file's private timeline the trace time.