Skip to content

Do not make it fail when args is empty. Rather return unresolvable in that case. #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 27, 2025
Merged

Do not make it fail when args is empty. Rather return unresolvable in that case. #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pytype/overlays/fiddle_overlay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,9 @@ def new_slot(
self, node, unused_cls, *args, **kwargs
) -> tuple[Node, "cfg.Variable"]:
"""Create a Config or Partial instance from args."""
# pass
if not args:
return node, self.ctx.new_unsolvable(node)

underlying = args[0].data[0]
self._check_init_args(node, underlying, args, kwargs)
Expand Down
13 changes: 13 additions & 0 deletions pytype/tests/test_fiddle_overlay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,19 @@ def f() -> fiddle.Config[Simple]:
return fiddle.Config(Simple, 1)
""")

def test_no_crash_on_empty_args(self):
# pass
with self.DepTree([("fiddle.pyi", _FIDDLE_PYI)]):
self.Check("""
from typing import cast, Any
import fiddle

def foo(*args):
return

fiddle.Config(foo, *[1, 2], 3)
""")


if __name__ == "__main__":
test_base.main()
Loading