Another fix to the argument handling in the functools overlay#1936
Merged
Conversation
copybara-service
Bot
force-pushed
the
cl/823476129
branch
from
141f000 to
4c70e5e
Compare
Turns out * positional arguments aren't necessarily present in `Signature.param_names`; * *args/**kwargs need special handling as well. PiperOrigin-RevId: 823630645
copybara-service
Bot
force-pushed
the
cl/823476129
branch
from
4c70e5e to
02e3f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix to the argument handling in the functools overlay
Turns out
Signature.param_names;