Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211.
Regexp.equals()compared only the runes forLITERAL/CHAR_CLASS, so alternation factoring (Parser.factorround 1) merged a folded literal with its case-sensitive twin and the fold leaked into the merged arm:(?i:Z)x|Zmatched lowercase"z"(the case-sensitive arm was effectively deleted). Go'sregexp/syntaxcomparesFlags&FoldCasehere; the port dropped it.This adds
FoldCaseto bothequals()andhashCode()(factoring groups via hashCode first, so the hash must agree with equality).Adds
FoldCaseFactoringTest: the fold no longer leaks ((?i:Z)x|Z,(?i:[Z])x|[Z]reject"z"), and both arms still match ("Zx"via the folded arm,"Z"via the case-sensitive one).Verified locally with
./gradlew checkon JDK 8: 1831 tests, 0 failures,verifyGoogleJavaFormat+licensegreen.Disclosure (as in #211): found while fuzzing https://github.com/jemmix/tdfa-jvm against re2j; patch and tests composed agentically with GLM 5.3 assistance; verification run locally by me.